Ben Howell comments

Results 15 comments of


                                            Ben Howell

Add custom light box component option

Thanks for the PR. Please see the discussion which includes future lightbox implementation ideas: https://github.com/benhowell/react-grid-gallery/discussions/179

Feature request: custom http headers, i.e. authorization header

Hi @ByteCrunch, I'm not sure what you mean re: Authorization header. Can you give me an example?

Feature request: custom http headers, i.e. authorization header

I understand what authorization headers are, can you give me an example of how you want to use them with react-grid-gallery? Do you want to use authorization on the src...

Feature request: custom http headers, i.e. authorization header

Sounds like a useful feature.

Grid column count is not stable

Thanks @ilkkao, it's not expected behaviour. You could be right, it sounds like a rounding error, most likely to do with how the row width is calculated. I've been able...

Square Grid

> this library is a joke, im building mine from scratch Good luck :-)

position: ignored when startup_mode: Fullscreen or Maximized

Oh yes, sorry. That is the case. ``` position: x: 1920 y: 0 startup_mode: Windowed ``` starts the terminal in the correct position and toggling fullscreen after that works fine.

position: ignored when startup_mode: Fullscreen or Maximized

Ok. 1. The bug is as I first reported. 2. Start in windowed mode then position is respected as I first reported. 3. Toggling full screen after starting windowed mode...

all_financial_data doesn't work for quarterly data.

Same issue is occurring for me with quotes (only started less than 24 ago): >>> from yahooquery import Ticker >>> aapl = Ticker('aapl') >>> q = aapl.quotes >>> print(q) HTTP...

all_financial_data doesn't work for quarterly data.

> Works for me. Linux, yahooquery 2.3.1, python 3.10.11 I just re-ran the code above and it still doesn't work. Can you post the output of this code: `from yahooquery...