Ben Halverson comments

Results 71 comments of


                                            Ben Halverson

npm start doesn't works

i wasn't able to reproduce this I'm on OSX 10.14.3 node 11.10.0 git version 2.18.0 npm version 6.8.0

Add winget commands in install tabs

@bnb Should we add this? Is it still in a preview state?

Create a best practices document

What should go in this doc? A lot of our practices are in the .eslintrc

Feat: Move to SCSS modules in site

What do you mean by scss modules? Is it the newer `@use` syntax https://css-tricks.com/introducing-sass-modules/

feat(i18n): introduce localisation capabilities and language toggle

I like this but I don't know if it should be displayed yet if there are no language files to switch to. What do you think? @obensource @joesepi

convert comment based action to be label based

If we switch to labels does that mean only members can start the ci and create a preview link?

Microsites Tracking

@bnb what's the ask for these microsites. Are they expected to be updated with the new design?

Microsites Tracking

ok i think this is doable. Under pages we could do something like `sites/metrics` and load a metrics.tsx page

Select and Integrate an i18n Library

@ghassanmas any interest in working on this

Select and Integrate an i18n Library

I would start with the gatsby plugins you mentioned and try to load the markdown files with the i18n lib that @zeke created here https://github.com/nodejs/i18n/pull/250 I think we should follow...