Ben Hall

Results 5 comments of Ben Hall

Hi @cyphersnake! Thanks for the PR, but before I review it, would you mind resolving the merge conflicts?

Hey, thanks for filing the issue! This one seems pretty interesting, in that it doesn't seem like there's necessarily a bug, but a better type definition for either or both...

> Is there a reason why we can't make the existing update function const? This is because Rust doesn't allow &mut in const fn functions yet. The tracking issue for...

Heya @emirror-de! The way forward here in my opinion is to implement this behind a feature flag. There happens to be an example of this now, with the `num` crate....

So I've had a chance now to think about this, there's basically two options. I would probably create a wrapper struct for arbitrary json values, and implement Diff on this....