bendk
bendk
Currently, enum/error with fields require the variant to use named fields. Take the example from the book: Rust: ``` enum IpAddr { V4 {q1: u8, q2: u8, q3: u8, q4:...
For #460, we added support for throwing errors with field data. However, now that I'm trying to use those errors, I realize they are missing an important feature from field-less...
In the logins component, we currently have code like [this](https://github.com/mozilla/application-services/blob/1dab6d76e9163a5bb8d6b17859cdf4f88458ea96/components/logins/src/error.rs#L16-L18) and [this](https://github.com/mozilla/application-services/blob/1dab6d76e9163a5bb8d6b17859cdf4f88458ea96/components/logins/src/error.rs#L83-L98). We create one error Enum, then wrap that as a variant of a top-level error Enum. I think...
When you uniffi an error enum, we create: - A top-level exception class corresponding to the enum - Nested exception classes for each variant - From what I can tell...
### Summary I'm having issues with entering my password with the firefox addon on Ubuntu 20.10. When I click on the addon icon, I see the list of matching entries,...
I would love to see the default `fml` mapping removed and instead simply allowing the user to choose their own mapping. A side effect would be that the FML mapping...
Replaced the error_support method with the new system that consists of: - `PlacesInternalError`: used internally in the crate. This replaces the old `ErrorKind` enum and is the error for `Result`....
Updating Rust for #5128 revealed that we have a handful of derived `PartialEq` impls that we don't use and many more that we only use in tests. As part of...
The current API has it returning a JSON-encoded string, but we never actually use it. We should try to change this code to not return anything. It seems that android-components...
According to clippy this is dead code. Should we remove it if it's not being used? https://github.com/mozilla/application-services/blob/b82517cde306274216874d6e6eec9f4042cdf9c6/components/support/nimbus-fml/src/intermediate_representation.rs#L722-L728 @jhugman (I moved this question out of the #5128 thread since I didn't...