application-services icon indicating copy to clipboard operation
application-services copied to clipboard

Should we derive less traits?

Open bendk opened this issue 3 years ago • 0 comments

Updating Rust for #5128 revealed that we have a handful of derived PartialEq impls that we don't use and many more that we only use in tests. As part of that issue, I fixed the clippy warnings by also deriving Eq. This leads to a question: if these derived impls are not used, does the linker remove the dead code or do they cause binary size to increase and if so how much. At some point we should check this out and consider not deriving some traits if there is some real-world cost.

┆Issue is synchronized with this Jira Task

bendk avatar Sep 13 '22 23:09 bendk