bendk

I think #1600 maybe addresses part of the issue here, but after that I see this error: ``` thread 'main' panicked at 'unsupported type for error: External { name: "UniffiOneError",...

> When I code in python, I alway use libraries split in several files and folders. I never met `from module import *` except in pwntools but in pwntools, we...

I'm guessing "pull in" means copied by `cargo vendor`. That's annoying indeed. I think inlining should be okay, the crate itself is very small. Another option would be to implement...

I forked the oneshot repo and made this commit that removes the `loom` target: https://github.com/bendk/oneshot/commit/1f3c657c8073aec4f0b6ebac7be33b4851644745 I think we can use this to keep the dependency simple in UniFFI and avoid...

This has been a real pain to maintain. Maybe we should create our own simple oneshot implementation using Mutex. The performance would be slower, but I'm not sure it would...

Yeah, I'm feeling like the tradeoff isn't worth it. It's very simple to implement this on our own and I don't expect this code to need much updating: https://github.com/mozilla/uniffi-rs/pull/2096.

Sure, please do.

I think you can do the same steps as the PR: - Change ` _Py_isFinalizing` to `Py_IsFinalizing` - Add a `#define` with a version check that defines `Py_IsFinalizing` for older...

Great! It looks good to me, but I'm just a user of the library. I don't have the power to approve the PR. Hopefully someone from facebook will.

I've tried addressing handles in many ways over the years. I'm hoping that we can come to consensus on this fairly easily. I don't think it makes sense to have...