Ben Demboski

Results 79 comments of Ben Demboski
trafficstars

Thanks for the issue! In my mind, I've broken this down into two separate issues: 1. Allowing `PageObject`s to wrap `DocumentFragment`s (this covers `ShadowRoot`s because they are `DocumentFragment`s) 2. Providing...

Oh, and have a look at #110 and tell me what you think -- as long as you don't see any glaring issues, I'll merge it and cut a release...

I'd definitely like to explore other options first. That would require doing our own parsing of selectors, which is something I'd very much like to avoid. `fractal-page-object` kinda tries to...

v0.5.0 released with low-level shadow DOM support

@sukima I've put some thought into this, and need to put some more in, but I think making the shadow DOM vs regular DOM distinction on the page object that...

@dfreeman I've addressed your feedback in a separate commit that I'll squash into the first commit if it all looks good

Okay, thanks for updating the code to the single-handler model! It looks to me like my above analysis still stands -- for Ember apps to be able to follow the...

@BobrImperator and @mansona that makes sense in isolation, but I'm still not understanding your full proposal for how this is used to implement the RFC. In what project does the...

@BobrImperator the idea behind `dom-element-descriptors` and the whole RFC was to implement a tiny (currently 406 bytes) micro-library that makes up for the fact that CSS selectors don't have an...

@BobrImperator no worries -- especially with widely used projects like `qunit-dom`, I totally get the importance of making sure we have the right solution even if it takes some time...