Ben Demboski

Results 75 comments of Ben Demboski

I see, it's related to the webpack plugin -- if you aren't using the webpack plugin it works fine. I think that's probably a bug in the webpack plugin because...

The webpack plugin [invokes](https://github.com/electron/forge/blob/f10aed29bc705afab9ed5ab1a12f982e74437082/packages/plugin/webpack/src/WebpackPlugin.ts#L161) `@electron/rebuild` itself, presumably because it needs native dependencies to be built for the current platform when running webpack? And `this.projectDir` is just the `dir` argument to...

The only thing I can think of is that you're calling `handleFileUrls()` before the app is ready? Is that possible? Can you verify that it's only ever being called from...

> Maybe somehow activate is happening in some cases before ready? I don't really know, but that would be my strong suspicion. You might do some MacOS testing to confirm,...

@jagthedrummer thanks for the detail! I think I'll just close this -- I'm not sure when I'll get to it, but I'm planning a significant overhaul to how `ember-electron` works...

@basz this is awesome! I've long wanted to figure out how to start writing main process code in typescript. Thanks so much for pioneering! Would you be willing to write...

Sorry, I don't really, I haven't had a chance to dig into this at all

Sorry, I'm not quite clear on what you want to be public. Is it `WithElement`? Or perhaps it would be better if it were `WithElement`?

If `selector` were public, it would only be the "leaf" page object's selector fragment, though. e.g. ```ts class Page extends PageObject { pane = selector('.pane', class extends PageObject { list...

Got it. Wanna PR an exported `getDescription()` (or something like that) utility function? I'm pretty pinched for OSS time these days. My last paragraph was in response to your `but,...