Ben Bowler

Results 160 comments of Ben Bowler

Hey @kelvinballoo, thanks for your QA. RE Issue 1, 2 and 6, the total width or your storybook window must be >1200px to load the desktop breakpoint, in these issues...

Thanks @kelvinballoo, updates below: ISSUE 2 : ❌: You can see the [tooltip version of the story here](https://google.github.io/site-kit-wp/storybook/develop/?path=/story/modules-analytics4-components-audiencesegmentation-audiencetile--ready-with-tool-tip). ISSUE 9 ❌: I made the margin bottom 16px in total rather...

Hey @kelvinballoo, the reason the title is hidden on smaller breakpoints is that, in these breakpoints, the `AudienceTile` component will be loaded in a [tabbed layout](https://www.figma.com/file/7pSrkEy8t00BcYRAi9LjjH/Audience-Segmentation?node-id=1936%3A22975&mode=dev) by the parent `AudienceTiles`...

[PR here](https://github.com/gemini-api-php/client/pull/40), I will test this with a project shortly and update it as needed. Feel free to test for your purposes @Martin-Matchory @Sinitra @DrAliRagab and let me know if...

I noticed [this library has an open tested PR for mimetype support](https://github.com/google-gemini-php/client/pull/23/files) so I'll close this one.

Waiting on #8138 to be merged then this one can be updated with develop and sent for review.

The failing test `MetricsSelectionPanel › Header › should display a settings link to edit personalized goals` appears to be failing across multiple branches rather than changes in this PR.

I've created the IB today, one thing to note and discuss in the IBR is that we could quite easily have the Consent Mode and Ads Module widgets both rendering...

Putting this into IBR, this comment from above still applies and is worth discussing: > I've created the IB today, one thing to note and discuss in the IBR is...

Thanks @eugene-manuilov, I've updated the IB module activation steps.