Ben Bowler
Ben Bowler
Hey @mohitwp, Q-1) You are correct, this ticket is just to show the button, https://github.com/google/site-kit-wp/issues/9338 and https://github.com/google/site-kit-wp/issues/9339 will make it work. Q-2) Our validation is very simple and just prevents...
Thanks @kelvinballoo, I've addressed all comments except point 4: > There are some designs adjustments based on figma for the edit mode. My thoughts is that pixel perfect changes to...
After testing this it's definitely not simple to jump straight to the latest version of puppeteer. However splitting the E2E infrastructure unlocks the upgrade pathway. I suggest we take the...
Hey @eugene-manuilov, based on the comment on the IB, the test PR #10020 does successfully split the E2E package to it's own package.json and updates the E2E workflow to be...
I'm un-assigning myself as the blockers are unlikely to be complete before my imminent parental leave. So far while we still have shared dependencies such as `@storybook/addon-storyshots` in the root...
@ivonac4 yes. It's waiting on the node upgrade ticket as many of these upgrade tickets are. Hence why I've not updated it yet.
@ankitrox you can take this over if you like.
Thanks @wpdarren, I've updated this title and will move to CR once checks pass.
@nfmohit i hadn't. I tried this on #11899 manually, so we can see if this causes undesired behaviour.
I'm changing the priority of this as it was highlighted by multiple testers in the PUE v0 bug bash so it is being noticed actively specifically in this epic so...