Benoit Bovy

Results 452 comments of Benoit Bovy

> figure out how to get rid of the UnitsStrippedWarning emitted by .pint.to, which happens because Dataset / Coordinates tries to create default indexes on quantified variables when assembling the...

You'd need to pass `Coordinates(variables={...}, indexes={})` to skip the creation of default indexes, or `Coordinates._contruct_direct` should work too (see https://github.com/pydata/xarray/pull/8107).

Ah yes, see https://github.com/pydata/xarray/pull/8107/files#r1311214263

> So right now indexes is a valid argument to the DataArray constructor but not to the Dataset constructor? Yes but this is really for internal use along with the...

Great to see this ready @keewis ! I went through the changes and it looks good to me (cannot tell much about the pint-specific logic, though).

I find the analogy with relational databases quite meaningful! Rectangular grids likely have been the primary use case in Xarray for a long time, but I wonder to which extent...

Another example (recent issue) in favor of stopping doing automatic index-based alignment: #7695. It is hard to report a meaningful error to end-users when alignment fails due to conflicting indexes...

> In the error message, we can recommend that the user call xr.align with the objects they're working with? Yes that would certainly be an improvement. I'm not sure how...

> It's a can of worms: Why to_xarray and not to_numpy(), to_PIL, ...? Why to_pandas() and not to_spark(), to_modin, ...? Instead of (or complementary to) `pystac` providing the API and/or...

I had the same issue and confirm that @michael-catanzaro's solution (adding quotes) fixed it. For more context, I'm using googletest via [s2geometry](https://github.com/google/s2geometry) and I'm not sure what @iiwolf said can...