Benoit Bovy

Results 452 comments of Benoit Bovy

@aufdenkampe, Indeed this repo has been very quiet for a while but is still actively used at least via `fastscape` and a couple of other applications that I'm aware of....

> Should I then perhaps fork and build from @feefladder's fork? Or can we work toward merging those PRs? It would be nice to eventually have this functionality available here....

@tdegeus good to know C++17 works well. I haven't had the time yet to experiment with this, unfortunately.

@keewis I have been looking into this once again and now I think I better understand what you'd like to achieve with the `PintMetaIndex` wrapper. A few other suggestions: ###...

nit: I would rename `PintMetaIndex` to just `PintIndex`.

Further comments: Implementing `Dataset.pint.dequantify()` would look very much the same than in `Dataset.pint.quantify()` except that it would extract the wrapped index: `new_idx = self.index`. For `Dataset.pint.to()`, I think it is...

Regarding all the errors in CI `TypeError: cannot be cast to a pandas.Index object`, an easy fix would be to implement `PintMetaIndex.to_pandas_index()` and just call that method for the wrapped...

> would that just delegate to the underlying index, or also wrap it (probably the former, but I wanted to make sure)? In the case of `.to_pandas_index()` just delegate is...

I think that in general it would be nice if we can keep a simple and predictable behavior for `.set_xindex`, i.e., we can use it with any Xarray Index leaf...

> is there a way to access this default index type? Not yet (I was thinking too much ahead). For now it is PandasIndex but maybe later we could add...