Ben
Ben
Hey @JyotinderSingh @arpitbbhayani @AshwinKul28, if this still needs to be worked on, I'd like to pick it up. Thank you :)
Hey @c-harish, Thank you for pointing out those issues. I should have tested this more thoroughly beforehand. The implementation has a couple of different issues which I resolved in my...
@c-harish I would continue working on the STORE and STOREDIST options.
@c-harish I looked into the implementation of STORE and STOREDIST this morning and I will need a few more days to finalize it. `STORE` and `STOREDIST` store the result of...
As far as I understand, the shard is determined by the key. The `STORE` and `STOREDIST` options take the result of `GEORADIUSBYMEMBER` and store it for a different key. Hence,...
Added the unit tests this morning. Will do benchmarking tomorrow and then we can decide whether to merge like this or add the `STORE` and `STOREDIST` options as part of...
## Benchmarks Base command ```sh Running tool: /opt/homebrew/bin/go test -benchmem -run=^$ -bench ^BenchmarkGEORADIUSBYMEMBER$ github.com/dicedb/dice/internal/eval goos: darwin goarch: arm64 pkg: github.com/dicedb/dice/internal/eval cpu: Apple M2 === RUN BenchmarkGEORADIUSBYMEMBER BenchmarkGEORADIUSBYMEMBER === RUN BenchmarkGEORADIUSBYMEMBER/Small...
Hey @apoorvyadav1111, any update on the review? I'm keeping it up-to-date with the latest changes, but let us know if we should request another reviewer :) We could unblock @c-harish...
Hey @JyotinderSingh , sorry for the late response here as well. I got caught up at work after new year and missed the notification. I'm picking the work on this...
Hey @JyotinderSingh, I have resolved the merge conflicts. As described above, I still need to implement the `STORE` and `STOREDIST` options. Based on my understanding, they will require to make...