Ben Ash comments

Repositories
Issues
Comments

Results 84 comments of


                                            Ben Ash

Periodically Cleanup Orphaned Shadow Secrets

@jaireddjawed let's hold off on bringing this change into the v0.10.0 release. I have moved it to the v0.10.1 milestone.

Inserted ttl to clean old jobs

Hi @luigi-bitonti - from our test setup running on K8s 1.32.0, the upgrade CRDs Job seems to be reaped after completion. Are you seeing something else on your side? Thanks,...

.Values.controller.manager.clientCache.numLocks being cast to str

Hi @seab4ng - thanks for reporting this issue. Are you passing any value overrides to the chart?

Add controller.extraLabels to pre-upgrade hook job

@satyamkapoor thank you for the PR. Would you mind expanding a bit on how these Job labels would be used? The upgrade CRDs job is consistent with https://github.com/hashicorp/vault-secrets-operator/blob/3b751445f42b2a92958b88d2cc725b588b71122f/chart/templates/deployment.yaml#L170 - in...