vault-secrets-operator icon indicating copy to clipboard operation
vault-secrets-operator copied to clipboard
verified publisher icon hashicorp

Add controller.extraLabels to pre-upgrade hook job

Open satyamkapoor opened this issue 1 year ago • 2 comments

With release auto CRD upgrade coming in with release 0.8.0, extraLabels were missed being honored in the helm pre-upgrade hook job. This PR, add's it.

satyamkapoor avatar Nov 04 '24 20:11 satyamkapoor

CLA assistant check
All committers have signed the CLA.

hashicorp-cla-app[bot] avatar Nov 04 '24 20:11 hashicorp-cla-app[bot]

@satyamkapoor thank you for the PR. Would you mind expanding a bit on how these Job labels would be used? The upgrade CRDs job is consistent with https://github.com/hashicorp/vault-secrets-operator/blob/3b751445f42b2a92958b88d2cc725b588b71122f/chart/templates/deployment.yaml#L170 - in terms of label configuration.

benashz avatar Jan 24 '25 21:01 benashz