Ben Asher comments

Results 142 comments of


                                            Ben Asher

Use processor count for number of default workers on Apple targets

I don't think you want `@ThreadLocal` though. I think you'd want it to be a global marked as `@SharedImmutable` and then have it be an AtomicInt

The number of workers should default to the number of processors rather than a fixed 4

Good point. Making it configurable makes sense. Mind making a PR?

Support for 32Bit Windows (mingwX86)

It should be! Do you have time to open a PR to try it out?

SupportSQLiteDatabase.setMaxSqlCacheSize(0) throws IllegalArgumentException

FWIW, Android has the same bug :/

Bumped Axios version to ">=0.25.0"

I think this is covered by #1192

s.prepare_command script is incompatible with find-utils

We ran into this issue and then realized we didn't have any use for `find-utils`. `brew uninstall find-utils` and then running `hash find` (to reset `find` back to `/usr/bin/find`) fixed...

podspec has no s.reources option,but packaging output contain Resource Foldder which not empty

Looks like your `s.source_files` might be too permissive. Try something like `s.source_files = 'LDRemoteCommand/**/*.{h,m,swift}'`

cocoapods-packager doesn't default to new CDN

You can workaround it by explicitly specifying the CDN: `bundle exec pod package --spec-sources='https://cdn.cocoapods.org/'`

Error: Module "path" has been externalized for browser compatibility. Cannot access "path.dirname" in client code.

This is definitely a regression. There are some packages, like postcss, which have parts that work in the browser and parts that don't. postcss is already [doing the right thing...

Error: Module "path" has been externalized for browser compatibility. Cannot access "path.dirname" in client code.

Yeah starting to agree with others that the behavior in Vite 2 was probably a mistake / oversight. Such modules should probably be polyfilled