Ben Asher
Ben Asher
PRs are welcome!
This should be fixed by #2365. Can you try `@benasher44/ajv`? I published that PR there
Since you're going for dual ESM/CJS, you might want to check "are the types wrong". For example: https://arethetypeswrong.github.io/?p=%40workos-inc%2Fnode%408.0.0-rc.2
👍 even if deserializing the queries is still required for Apollo Client, it looks like it might still be a win for web bundling. Thanks for the consideration!
Downgrading to 4.12.0 seems to fix the issue.
@epoberezkin I think this is ready for review now, and I'm now just hitting the node 14 build issue plaguing the main branch. Maybe we can disable now that node...
Okay yep this is ready. You can see the build passing on the other builds in https://github.com/ajv-validator/ajv/pull/2365/commits/b7b5fd0861baa89d702d7d36e01c0a76eb4b50c3, where the only change I did was temporarily remove 14 from the matrix.
Pushed more updates + confirmed the build pass without node 14
Thanks @jasoniangreen! Let me know if you have feedback on this PR — would love to move this forward
That's totally fair! Would you consider just adding named exports for the classes alongside the default exports? The main pain point is the default exports. If people have the named...