Ben Manes

Results 518 comments of Ben Manes

Using merge is a bit odd since that is a forced write, whereas computeIfAbsent is usually the behavior that you want. That does a read before falling back to a...

That sounds like a good reason to use merge, thanks for clarifying. Note that if you are not already using it in Guava, be aware that their computes have had...

It’s to hard to say given a busy week and the holiday season. I might get to it this weekend, or not. I can’t say tbh.

See `ArrayUtils#shuffle(int[])` in Apache Commons Lang3.

This may be too invasive of a change for the Guava team to resolve soon. For the short-term, I'd see if your datasource supports multi-get escalation to collapse a sequence...

The issue also manifests in `getAllPresent`. It may be best to fix it there and then have `getAll` delegate to it instead of `get`.

I think this should be closed and users directed to use their favorite Reactive Streams library. See this [example](https://github.com/ben-manes/caffeine/tree/master/examples/coalescing-bulkloader-reactor) using Resctor, which could trivially be adjusted to complete Guava’s ListenableFuture.

fyi ehcache2 is fully end of life (no maintenance or critical/security fixes)

@keddie is correct. A common misunderstanding with Caffeine's refresh is when users think of it as a periodic reload of the content at the fixed delay. That's a (unbounded) periodic...

Removing the whitespace did not help. The multi-valued configuration is [documented](https://pmd.github.io/pmd/pmd_userdocs_configuring_rules.html), so perhaps that capability was removed for this rule?