Ben Krieger

Results 41 comments of Ben Krieger

The root cause of this issue is that downloaded layers aren't written to a temp location and then moved after complete download and verification. I would be happy to contribute...

One option would be to automatically delete undersized layers in the cache like this: ```diff diff --git a/src/cmd/linuxkit/cache/write.go b/src/cmd/linuxkit/cache/write.go index 172f6fdfd..083e902dc 100644 --- a/src/cmd/linuxkit/cache/write.go +++ b/src/cmd/linuxkit/cache/write.go @@ -13,7 +13,7 @@...

FYI: This is a known issue in google/go-containerregistry: https://github.com/google/go-containerregistry/blob/7c19fa370dbd0179c9ce73a0432bf826f174c775/pkg/v1/layout/write.go#L247-L248

One solution, though ugly, would be to simply modify the vendored copy of go-containerregistry. This has the downside of being difficult to maintain through updates, but it's a very small...

I discussed this with another developer and they suggested an alternative that I think is better than either of my prior two suggestions: We could add a `linuxkit cache autoclean`...

@djs55 Thanks for weighing in. As I started playing around to see what the implementation would look like, I found myself adding to and improving `(*cache.Provider).ValidateImage` to do the checks...

Testing on Ubuntu 20.04 from commit `be43e9931`: Go 1.16 builds fine. ``` $ eval "$(gimme 1.16.12)" && make local go version go1.16.12 linux/amd64 make -C ./src/cmd/linuxkit local make[1]: Entering directory...

> Thanks for your effort. I would prefer an implementation using [rendering hooks](https://gohugo.io/templates/render-hooks/) as this approach can be used for other extensions e.g. KaTeX as well. This way, it should...

And the solution is literally given in the docs... https://gohugo.io/content-management/diagrams/#mermaid-diagrams But there is a small amount of work needed to integrate with the existing mermaid shortcode so that using a...

> The shortcode has already a check using the exact same code in the render template should avoid double imoorts. I just mean change `.Page.Store.Get("hasMermaid")` from the doc example to...