Ben Harris comments

Repositories
Issues
Comments

Results 2 comments of


                                            Ben Harris

Use `outputVar` instead of hard coding `this.output` in JS codegen

CI is failing for this, but I'm incredibly unsure why or what's going wrong here. I'd greatly appreciate any assistance that folks could provide on this! EDIT: Yeah, [Java's failing](https://github.com/apache/thrift/actions/runs/8393509381/job/22999021570?pr=2950),...

The generated commonjs `*_pb.js` files don't work in Node.js environment

FYI, this was fixed in [3.19.x](https://github.com/protocolbuffers/protobuf/blob/633cef56e8a2e8f009c5f79d4250c04c03367143/src/google/protobuf/compiler/js/js_generator.cc#L3637) by [PR #9156 in the old repo](https://github.com/protocolbuffers/protobuf/pull/9156), but regressed to the old behavior. I've verified that this works with protoc version 3.19.4, but fails...