belugabehr
belugabehr
@jteagles I create a small driver with JMH: ``` Benchmark Mode Cnt Score Error Units TestSplit.master thrpt 30 5324642.492 ± 228078.761 ops/s TestSplit.tez4365 thrpt 30 1809324.533 ± 37792.272 ops/s ```...
@jteagles Just wanted to get your temperature on this change. Thanks!
How do we update the build system to call out to this new spot bugs?
@abstractdog Hey, can you please take a look at this PR once more? Thanks!
@abstractdog Able to take a look? :)
What message would that be? Happy to update it.
@jteagles Updated as requested. Thanks!
@dossett Thanks. There's a bunch more I'd like to add, but this is already a lot. Also check out: https://issues.apache.org/jira/browse/PARQUET-1914
> I like this very much. Would it be possible to have a test to check the output of the template? Great! I started working on some of the more...
OK. I added a unit test. I don't love the test, but it's something (and better than nothing). I'm also not sure how good of an example it will be...