John Belmonte

Results 252 comments of John Belmonte

a script to run benchmarks was added recently: https://github.com/facebookincubator/cinder/commit/77d5d1f55a50b9e099238c9e4f177ee8d668c646

workaround is to explicitly cast the float literals to double: ```python c += foo(double(.4), double(.97)) ``` it's surprising to have `@inline` change the conventions of implicit conversion of the args

Thank you. Would it not just be a matter of having an alternate flag (JIT_START_DISABLED) and in that case `_PyJIT_Initialize()` will leave `jit_config.is_enabled` at 0? If so I'm happy to...

> At the very least you'd need to go through and review all the call-sites that check to see if the JIT is enabled and make sure they support this...

@jbower-fb from my attempts, `-X jit-capture-interp-cost` hasn't worked out too well: **The counts seem to include the cost of children in the call stack**, which isn't what you'd want for...

The accounting problem may be specific to ~async~ the async library we're using (Trio)-- I'll try to give a specific repro. > The cost of compiling JIT functions is really...

update: * after looking a little closer, I couldn't find a problem with `-X jit-capture-interp-cost` accounting * I attempted enabling various combinations of the top 20 or 30 items in...

I didn't notice a change from `-X jit-no-type-slots`. > this shouldn't be very much unless you're invoking a large number of new functions throughout the program's execution. I would say...

I don't know how to use `perf` offhand, but I fumbled around with it using `perf top -g -p ...` and then filtering on PyEntry. It seems to confirm the...

There may be a gross inefficiency with `-X jit-enable-jit-list-wildcards`. With that option removed, the overhead is only 0.5% (still high, but 4x better). empty jit list (wildcards disabled): ![Screen Shot...