John Belmonte

Results 252 comments of John Belmonte

Also, implementing only `__eq__` is bad, see #163

#164 is merged, so `repr(a) == repr(b)` should be sufficient for this use case

I mentioned before and filed a bug, but implementing only `__eq__` is problematic. https://github.com/mido/mido/issues/163

> Other than that my code should work. Would you agree? Actually, I didn't know that List `__eq__` compares the lists element-wise. Your proposal seems like it should work, though...

I see, implementing `ne` is only required for Python 2. It looks like the recommended solution is implement `ne` as `not self == other`. https://stackoverflow.com/questions/4352244/should-i-implement-ne-as-the-negation-of-eq-in-python/30676267#30676267

``` Parser/listnode.c:66:1: error: ‘/cinder/Parser/listnode.gcda’ profile count data file not found [-Werror=missing-profile] ``` I'm seeing this error too on a stock `ubuntu:20.04` docker image. Though I notice it only came up...

The build failure is a known issue and tracked in #74. More cases don't need to be cited.

More runs looks better. Some benchmarks still slower. ``` $ time ../../python.exe fannkuch.py 20 real 0m29.641s $ time ../../python.exe -X install-strict-loader -X jit fannkuch_static.py 20 real 0m17.892s $ time ../../python.exe...

better with the jit-list constraints (static nqueens still much slower overall) ``` $ time ../../python.exe -X install-strict-loader -X jit -X jit-list-file=jitlist_richards_static.txt -X jit-enable-jit-list-wildcards richards_static.py 200 JIT: Jit/pyjit.cpp:925 -- Enabling wildcards...

About managing jit-lists, it seems to be tedious in general for applications, and wildcards have known performance problems (#29). I wonder if it would be easier all around to have...