John Belmonte

Results 252 comments of John Belmonte

If this were possible then the `forceUploadAndMonitor` setting could be eliminated (because you could just map the upload button to the Upload And Monitor task).

Wondering if asks should catch the MultiError ConnectionRefusedError and re-raise as ConnectionRefusedError. @njsmith what's a library to do in this case?

I'm not suggesting aliasing ConnectionRefusedError. Simply re-raise the MultiError of (ConnectionRefusedError, ConnectionRefusedError), which is an implementation detail, as ConnectionRefusedError. Trio MultiError already has utilities for filtering and catching MultiErrors. I...

@njsmith thank you for clarifying that. ~I'll follow up on trio about improving the exception message.~ @theelous3 re-raising something like `asks.ConnectionFailedError` doesn't sound bad to me, especially if there could...

Actually there is more to this. `open_tcp_stream()` only takes a host and a port. So an issue is that asks is not identifying the lack of a scheme earlier. It's...

njsmith wrote: > So... there's a question whether asks should catch the OSError and replace it with something like an asks.ConnectionFailedError. I can't answer that; it's something the asks devs...

> This was resolved in ced7a74 I don't think so, since that commit predates the problem report by a year.

if type hints will be added, I think that the CI must run mypy to ensure the annotations are correct and prevent future regressions

thank you for working on it I think it will need unit test coverage. It's good to write the test and verify that it fails before applying the fix.

That async_lru doesn't seem to care about parallel cache misses having identical args, which seems like a significant case for async. In my project we, don't have a need for...