can raise RequestTimeout on connection timeout

[belm0]

in request():

sock = await timeout_manager(
     connection_timeout, self._grab_connection, url)

so this is establishing a connection, not making the request. Yet timeout_manager() will raise RequestTimeout.

Overall it would be helpful if exception cases are documented for request().

[theelous3]

Fair point. I lazily reused that for both the connection and the request, rather than give them a base class.

I'll sort this and slap it in the docs :)

[PurpleMyst]

This was resolved in ced7a74a

[belm0]

This was resolved in ced7a74

I don't think so, since that commit predates the problem report by a year.

[theelous3]

Yeah no, @belm0 was asking for two separate possible exceptions:

ConnectionTimeout on failed connection attempts. RequestTimeout on successful connects where the server didn't respond to the https request on time.