Dmitry Belyavskiy

Results 454 comments of Dmitry Belyavskiy

The pkcs11-provider external test has finally passed. Ready for review.

I think that it's reasonable having a raw file as an SKEY format (implying that the interpretation of it as raw bytes data is requested explicitly). What you propose looks...

@levitte I basically agree but implementing a separate store support is beyond my capacity.

@levitte I can drop this part of the PR - but it means that the new functionality would be tested only via external tests :(

@levitte the problem is that there is basically no format for secret keys except plain text. [RFC 6031](https://datatracker.ietf.org/doc/html/rfc6031) is dead. [PKCS#12 in theory can support it as a separate bag...

We already have an updated version of pkcs11-provider for external tests so I dropped the corresponding commits. @mattcaswell @levitte @paulidale @t8m could you please review?

The fuzzer failures seems irrelevant Ping @openssl/committers for the review

Do we need also removing the similar API for! EVP_MD or it's already removed?