Dmitry Belyavskiy
Dmitry Belyavskiy
@DDvO could you please resolve the conflicts? I think this API change is suitable for 4.0
TODO - [x] fix pkcs11-provider test - [x] add tests for new `enc` and maybe `storeutl` options - [x] deal with `find-doc-nits` failures - [x] document file_store changes
Waving style because the original functions were already longer than 200 lines. All the rest issues are resolved
I believe that this PR is conceptually ready for review. The pkcs11 test failure seems to be discussed at the pkcs#11 provider side as of now
Commenting the code around `OSSL_OBJECT_SKEY` in pkcs11-provider makes tests passing so it's an issue in pkcs11-provider
OK, after fixing the PKCS11 provider issue I see that the PR is to be adjusted a bit more.
The OQS provider failure seems irrelevant. pkcs11-provider test failure is relevant but requires some efforts from their side (https://github.com/latchset/pkcs11-provider/pull/618 is a draft PR). I think the PR is ready for...
Yes. I have a PR to fix the issue there - but it's a sort of Catch 22
Yes, it's an option. The maintaner of the pkcs11-provider returns the next week, but grooming may take some more time (just rebasing to the latest version of the pkcs11-provider doesn't...
Looks like it didn't help - @The-Mule could you please make a second look?