Ben Doherty

Results 13 issues of Ben Doherty

**Describe the bug** Flickering inside of gltf_viewer when resizing the window with the Metal backend. **To Reproduce** Steps to reproduce the behavior: 1. Run `gltf_viewer --api metal` 2. Resize the...

metal

Will update RELEASE_NOTES when the Material API is added, otherwise at the moment there's no way to use the stencil buffer.

internal

This switches Metal to use [argument buffers](https://developer.apple.com/documentation/metal/buffers/about_argument_buffers?language=objc) for referencing samplers and textures in draw calls. Argument buffers are similar to Vulkan descriptors. The primarily reason for doing this is to...

https://github.com/google/filament/blob/9e87a312abc644608f281e6b17f129cb26da0f9b/filament/backend/src/SamplerGroup.cpp#L42-L51 The "correct" solution is to "clear" the texture handle from any referencing `SamplerGroup` when we destroy a texture. Not sure how feasible this is.

enhancement

Throw an NSException when a program fails to compile and then is used for drawing; this helps aid debugging compiler errors in production, where stdout logs are not available. b/325321035

internal

For generating MSL, turning off `--optimize-size` optimization passes (still keeping the ones necessary for fp16), reduces sizes of lit materials by nearly 400 KiB: - sandboxLit.mat: 376.6 KiB savings -...

internal

**Describe the bug** Debug builds of gltf_viewer crash when loading the SheenCloth.gltf sample model. ``` in void utils::panic(const char *, const char *, int, const char *):32 in file ../../libs/utils/src/debug.cpp...

bug
gltf

On Apple platforms, we should be throwing an `NSException`, which gives us better crash reporting.