Carsten Behring
Carsten Behring
The question is if that should happen then "for everybody". It makes the container a bit slow, and it uses always "latest version" of vega editor. A user could later...
I added the setup of yarn link. Just have a look and decide, if we want this "automatic" for everybody. In theory this could become "user dependent" and rely on...
The above error is a conflict of extensions and ruby, I think. It works for me, even with error message.Mayube goes away by using ruby 2.7 as feature.
The "feature" only works with vs code base images, not with "node" base image. Don't want to go back to that. So ruby will be installed with "apt"
Addressed review comments in one commit
> Please run `yarn format` @behrica done
> The docker test is failing: https://github.com/vega/vega-lite/runs/4253502607?check_suite_focus=true. I run it locally with "act" (https://github.com/nektos/act) and it passed. and the "-ti" parameter should activate the TTY
There is a known timing issue related to TTY detection. I will put a short "sleep" in front. But just a guess.
I would not know better then try all 4: ``` docker run -v `pwd`:/app -w /app vega-lite-devcontainer yarn build docker run -t -v `pwd`:/app -w /app vega-lite-devcontainer yarn build docker...
> Can you merge the last two commits? Somehow the tests don't run. It says "waiting approval" : https://github.com/vega/vega-lite/actions/runs/1478059060