Carsten Behring

Results 517 comments of Carsten Behring

I restarted the PR from scratch. This time with generation of the edn files as part of the build.

I will wait until this is merged: https://github.com/vega/vega-lite/pull/7807 Then we have an easier way tu bring "jet" and "puget" intote dev environment.

> Actually, should we instead provide a vscode dev container? Good question. This would need a "custom dockerfile" in any case. So we are on the right track. "Gitpod" is...

A vs code devcontainer json files can just point to an existing Dockerfile in the repo. So it could indeed be added later, in a different PR.

The devcontainer json seems to support "most"/all of the options I put in the docu. Nevertheless there is a small risk, that either the Dockerfile or the "standalone Docker usage...

I am hooked in ... into vscode and remote containers..... It is just great and it "automates" all the docker build settings, and does the "right" thing automatically. If you...

I found dev-containers so useful, that I went ahead and added the dev-container setup. Dockerfile did not needed to be changed. I replaced the docker build instructions, with VS Code...

I am not familiar with the vega-lite / javascript / typescript development workflows. I believe that the "yarn xxx" commands work. (at least they run without obvious errors ...) Somebody...

It seems to work; First: cd ~ && git clone https://github.com/vega/editor.git Then: ``` node@ab7c7c77b09f:~$ cd /workspaces/ node@ab7c7c77b09f:/workspaces$ cd vega-lite/ node@ab7c7c77b09f:/workspaces/vega-lite$ yarn link yarn link v1.22.15 success Registered "vega-lite". info You...

"closing vscode" will not make the content in $HOME (such as `vega-editor`) disappear. But " rebuild" of the dev container would. The "cd ~ && git clone https://github.com/vega/editor.git" could be...