Behdad Esfahbod
Behdad Esfahbod
Is the `.dll.def` useful?
I started this in https://github.com/harfbuzz/harfbuzz/commit/aab6060b6cdc33e29e576e599693b749cc05fe60 but that was incomplete and only worked for instancing and only for minLeadingBearing.
There's a couple different things: - When instancing, we should recalc bounds. - When not instancing, it should be an option. FontTools has this: ``` --recalc-bounds Recalculate font bounding boxes....
This was fixed by @qxliu76 for instancing already.
FontTools PR that can generate this format. https://github.com/fonttools/fonttools/pull/3242
Yeah this is a known issue. We don't want to use saturating math everywhere. Using floats is my preference but breaks our ABI. Just limiting the font scale at entry...
> Just limiting the font scale Humm. That's not possible because there's no number that will ensure there's no overflow. For example a font can have stacking diacritics...
A font scale of 0xFFFF is very reasonable thing to use so I don't want to put the limit lower than say 0x00FFFFFF. If there the fuzzer can still find...
The problem is, fuzzers can make the upem very small, glyph very tall, string very long made of marks. This will overflow any reasonable scale limit.
I'm fine limiting scale to upem*0xFFFF.