Maxim Borisov

Results 8 comments of Maxim Borisov

Hi! I assume you are aware of this, but still want to point out that current implementation doesn't work well with type checkers and auto completion. Consider this example ```python...

> Of course a big issue with the above is that `Concatenate` and `ParamSpec` require Python 3.10. So I guess any change like the above would need to be wrapped...

> > I'm tinkering with this a bit as well. Concatenate and ParamSpec are available in [typing_extensions](https://pypi.org/project/typing-extensions/) which is already a dependency. > > Oh yes, great point! I forgot...

FYI I've opened a PR for this issue https://github.com/roman-right/beanie/pull/886 Sorry it took few days, got distracted

Looked at the implementation - `fetch_all_links` doesn't implement fetching `BackLink`s. Maybe @roman-right accidently forgot it. In this case the following happens: 1. `Document.fetch_all_links` calls `Document.fetch_link` for each link 2. [This...

The problem with `Unknown` is not because of the `Link` class but because `LazyModel` (which is parent of `Document`) defines `__getattribute__`. So type checker thinks "maybe this field is dynamic,...

btw, duplicate https://github.com/roman-right/beanie/issues/820

@tristandeborde > Did you end up opening an issue in Lazy Model? No, since I got no reply from the @roman-right. I assume he's busy with some other work, because...