Beau Rancourt
Beau Rancourt
summarizing the broad approach to make sure I understand: 1) we call `rewards.sh` from arguments somewhere (from a service, manually, etc). That parses arguments, and eventually... 2) we call `rewards-requirements.ts`...
Here's a little audit on the prometheus queries: ``` 1) present_over_time(up{chain_address="0x0954efEFeb970D317a51736201B4EB2De75FF5DE", job="keep-discovered-nodes"} [2591999s] offset 74124s) 2) up{chain_address="0x0954efEFeb970D317a51736201B4EB2De75FF5DE", job="keep-discovered-nodes"} [2591999s:120s] offset 74124s 3) sum_over_time(up{chain_address="0x0954efEFeb970D317a51736201B4EB2De75FF5DE", job="keep-discovered-nodes"} [364679s:120s] offset 74124s) * 120 /...
Okay! left some misc review but it's all non-blocking. The code works as-is and is ready for use, so I'm going to ship it! Totally down to handle other concerns...
Big bumparooni here. If you want to pick a service and PM me about how you want to handle the API keys, I'll write it and spin up a PR.
I looked into it - imgur's search API wasn't built for non-tagged image searching. One of the better API's that I've found is https://www.microsoft.com/cognitive-services/en-us/bing-image-search-api but the free tier is limited...
Left a non-blocking suggestion for a footnote: I'm good after @michalinacienciala / @lukasz-zimnoch is good!
Is this good to merge?
I'm going to merge it! If we want to go back and touch it up, I think that can be a separate PR, and I think having rfc-7 in main...
Okay, so that I understand this card, do we want: a) A PR against https://github.com/keep-network/bitcoin-spv and potentially a new release that adds more test data b) A PR against https://github.com/keep-network/tbtc-v2/...
In either case, we're going to need a truckload of eth to pay for all of the gas for the redemption transactions, but here are the two fundamental options that...