Tim Hsiung

Results 76 comments of Tim Hsiung

I will rebase this branch after #1726 is merged. The test failure should be resolved then.

pls run though our pr checklist (you should see it upon PR creation) to pass the PR pipeline. just quickly scanned through your changes, looks like you didn't run `poetry...

The possible solution LGTM. @woile @Lee-W wdyt?

Then user needs to type `--config` every time they run `cz` (iirc there is no corresponding configuration file option for `--config`) I think that is bad user experience.

iirc most of the time `package.json` is located at project root, but there may be exceptions can't the problem be solved by just specifying `version_files`?

Hi @YazdanRa , thanks for your contribution! I wonder how monotonic versioning works. It would be great if you could provide some references. The only reference I could find using...

I would ask AI to provide naming suggestions. Naming is hard. "Monotonic" has nothing to do with "single". Probably "Single number version" or "Monic version"? (I haven't checked if the...

I believe the type of `version.release` should be `Tuple[int, int, int]`, although it's `Tuple[int, ...]` on master now. Is there any reason you think the change should be at core...

If I understand correctly, the basic assumption for commitizen version providers is that the release version number always consists of three numbers. @woile @Lee-W wdyt

Hi @vemilano , We are planning to merge the branch v4-10-1, which contains changes in `cargo_provider.py`, into master branch. You can resolve the potential conflict on this PR after we...