Robbert Gurdeep Singh

Results 16 comments of Robbert Gurdeep Singh

Hmmm, I feel like this could be automated and should not be in the markdown file. Maybe a GitHub action could make a nice HTML page to serve trough GitHub...

The :one: and :two: emojis could also be used as "badges".

> @beardhatcode @skjnldsv I suppose we want some non-regression test to be added to viewer's automated test suite? Yes > Maybe we can setup a mini video folder, have viewer...

Oh and you should also test video's and captions with odd names like: ``` this 🎥 has 🗨️🗨️🗨️ subtitles🕵️‍♀️ %20.mp4 this 🎥 has 🗨️🗨️🗨️ subtitles🕵️‍♀️ %20.en.vtt ```

I have been thinking, wouldn't it be better to use the fileid in the API (no escaping issues). And, with @CarlSchwan search suggestion we can try all the locales :)....

Thank you for reporing this @kalsan. I looked in to this and it seems to be caused by a missing Authorisation header when the delete is invoked from the viewer...

Pffff, I have been looking in to this a bit, and I think it might be best to call `OCA.Files.App.fileList.do_delete("filename")`. Or have some other way of reusing the functionality of...

@marcelklehr, could you give an example usecase? What kind of app are you building?

You could just use `URL` and match in the opposite direction ```js new URL("https://аптекамелисса.рф").href // ⇒ "https://xn--80aaasbslkh0a3aae.xn--p1ai/" new URL("https://github.com").href // ⇒ "https://github.com/" ```

Hmm, thats true. This is what I had in mind: ```js "some/dir/аптекамелисса new" .replaceAll(/[^:/ ]*/g, (part)=>part ? new URL("https://"+a).host : a) // ⇒ "some/dir/xn--80aaasbslkh0a3aae new" ``` But here I replaced...