Dragan Bozanovic
Dragan Bozanovic
I couldn't reproduce it on my machine. It happens for Jonathan on a macbook with touchpad (he cannot reproduce it on Windows).
@cpovirk Thank you for the details, I submitted PR #5121 to add `RedundantNullCheck` bug pattern.
@cpovirk Many thanks for the detailed review, I'll take a look at the suggestions.
@cpovirk Great, thank you, I incorporated and pushed your suggestions (with two additions - implicit vars which aren't parameters and literal initializers). Also added tests for the new use cases.
@cpovirk Also we think that extending this with support for redundant `Objects.requireNonNull` calls would be beneficial, wdyt? If you agree I will also push it here - I already have...
> > @cpovirk Also we think that extending this with support for redundant `Objects.requireNonNull` calls would be beneficial, wdyt? If you agree I will also push it here - I...
> The results from running this over our depot look excellent—so many people who think that methods might return `null` when they actually throw an exception, for example, plus all...