J. Nick Koston

Results 1005 comments of J. Nick Koston

> Also, do we want discovery of the native API to not happen when discovery using Home Assistant MQTT protocol is enabled? Maybe that's not an issue since discovery over...

Could be the same issue as https://github.com/home-assistant/core/issues/115354 See the section `Enabling asyncio debug mode at run time (preferred)` in https://community.home-assistant.io/t/2024-5-tracking-down-instability-issues-caused-by-integrations/724441

> 2\. It should only be set for devices that support the open action ([Add august open action #113795 (comment)](https://github.com/home-assistant/core/pull/113795#discussion_r1530761482)) However, I have no idea what the best way is...

> We could go by the lock model and compare it to a list of models that Support opening. If we hide that behind a property or function in `yalexs`...

lib bump in https://github.com/home-assistant/core/pull/116511

Code looks good. Should be good to merge once tests are added

It looks like you might be manually trying to fix ruff issues. I'd recommend installing `pre-commit` https://developers.home-assistant.io/docs/development_testing/

You'll need to copy the fixture and than add a new one in https://github.com/home-assistant/core/blob/63484fdaddaca7ec92ed95376a94b8fb2b1daa97/tests/components/august/mocks.py#L365

If the model id is not in diagnostics, it would be nice to add it there as well

Please send a pull request for this.