J. Nick Koston

Looks like a run-away template

Please follow the instructions at https://community.home-assistant.io/t/2024-5-tracking-down-instability-issues-caused-by-integrations/724441 to identify it

I'm not 100% sure that this problem is fixed, as there wasn't anything specifically for templates in 2024.5.2. Perhaps it was the statistics fix? Do you use the statistics integration?...

I was hoping to be able to do another review pass on this before I'm flying all day tomorrow but it looks like the day got away from me. I'll...

Tested. Everything looks good. Was able to switch from v2.5 to v3.0 and back.

I'm still traveling until Thursday, but I wanted to give you feedback on the issue so we can be sure to get it in before beta.

Please avoid doing force pushes once review has started as it means we have to start over and compare everything again

LGTM. I don't actually use mqtt with esphome so it will need another reviewer to take a look before merging

https://github.com/esphome/esphome/blob/5edf4970bde1d2d5dda2fa34c1ba062a8f3aa8a1/esphome/components/mqtt/mqtt_client.cpp#L84 Relevant ESPHome code for context

The ESPHome dashboard does support MQTT discovery for remote ESPHome devices that may be on different networks/over WAN https://github.com/esphome/esphome/blob/5edf4970bde1d2d5dda2fa34c1ba062a8f3aa8a1/esphome/mqtt.py#L149 https://github.com/esphome/esphome/blob/dev/esphome/dashboard/status/mqtt.py