J. Nick Koston
J. Nick Koston
You have modified clang-tidy configuration but have not updated the hash. Please run `script/clang_tidy_hash.py --update` and commit the changes
clang-tidy is failing on zephyr ``` Error: /home/runner/work/esphome/esphome/esphome/components/dsmr/dsmr.h:8:10: error: 'arduino-dsmr-2/fields.h' file not found [clang-diagnostic-error] 8 | #include ```
So now we need a docs PR linked. Once the docs PR is linked, the bot will remove the needs-docs label. Also be sure to update the Arduino to ESP-IDF...
I'm a bit behind on the events here. I was expecting the esphome-libs version would be in this PR. Can you summarize what happened there?
This PR is quite large and invasive. I'm a bit concerned that the test coverage isn't sufficient to cover the scope of it.
> Yes it looks very large, it is untying a big knot with how variables are handled everywhere. This PR is part 2. Perhaps you could look at part 1...
@jpeletier please resolve conflicts when you have a free moment. Thanks!
The complexity here is making the review take a lot of time. I asked claude to build a diagram of how this works. In case its helpful: ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │...
This approach of dynamically mixing context into YAML nodes is similar to what Home Assistant's [annotatedyaml](https://github.com/home-assistant-libs/annotatedyaml) library does. Have we considered whether there's potential for shared infrastructure, or is ESPHome's...
Looks like we need a test for https://github.com/esphome/esphome/issues/12559 case as well