J. Nick Koston

Results 2087 comments of J. Nick Koston

We also have a pending upgrade to aiohttp 3.9.0 which has some more fixes in this area which might also be a contributing factor. I'm not sure that will make...

I pushed some readability improvements. If it works for you, its good to merge from my perspective

I tried reproducing this with stunnel ``` ; stunnel configuration for TLS proxy to ESPHome dashboard foreground = yes pid = /tmp/stunnel-proxy/stunnel.pid [esphome-tls] accept = 6053 connect = 0.0.0.0:6052 cert...

So it seems this is likely either a https://github.com/home-assistant/supervisor/ or https://github.com/home-assistant/core issue and isn't specific to ESPHome.

Is everyone with the issue using `ESPHOME_TRUSTED_DOMAINS` ?

> cleanup_closed could use some improvements. Something to investigate for sure. > > > This one is heavy. Should make it a priority. It might just be because of the...

The cleanup_closed case is because its every 2.0. HA changed it to 60.0 but there are lot of places where libs don't use HA's subclassed connector so we still see...

> > > web_protocol.py:.keep_alive(): Should we cancel if the val is already the same and a handle already exists? > > > > > > This one doesn't seem to...

I didn't see client_proto.py:`_reschedule_timeout` ever schedule a timer because it looks like everything in HA is using a total timeout and not a read timeout. Its going to churn if...