core icon indicating copy to clipboard operation
core copied to clipboard

Add flow detection to Rachio hose timer

Open brg468 opened this issue 7 months ago • 2 comments

Proposed change

Rewrite binary sensor to use entity descriptions and add flow detected binary sensor to the hose timer.

Using a problem sensor for flow not detected. The reason I didn't choose moisture sensor was I didn't want the state of the sensor to change every time the valve turns on if flow is detected (normal condition), which would make it harder to use as a trigger IMO. Open to suggestions on other ways to handle it though.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

brg468 avatar May 01 '25 21:05 brg468

Hey there @bdraco, @rfverbruggen, mind taking a look at this pull request as it has been labeled with an integration (rachio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rachio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rachio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar May 01 '25 21:05 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 09 '25 16:05 home-assistant[bot]

Thanks @joostlek!

brg468 avatar May 13 '25 16:05 brg468

I pushed some readability improvements. If it works for you, its good to merge from my perspective

bdraco avatar May 14 '25 04:05 bdraco

Looks good to me. Thanks @bdraco and @joostlek!

brg468 avatar May 14 '25 12:05 brg468