Brandon Liu
Brandon Liu
Updated in https://github.com/protomaps/basemaps-assets/commit/853acf2ca75c00bb926644ce6904a6235337e921
1. not if it requires all users to use `pnpm` 2. for modern exports, do you mean changing the exports? this would be a breaking semver change 3. I have...
> Additionally, making this a native ESM library would be preferable and if people insist on using cjs they can just transpile this dependency. Isn't this already the case? The...
Thanks for the example. We need to stay on Node 18 instead of 20 because AWS Lambda doesn't have Node 20 yet. In general, I'm OK with the packaging set-up...
1. The Leaflet situation should be isolated to `adapters.ts` - Leaflet does not use ES6 imports, it relies on the global L. It's important for the PMTiles project to support...
Added Biome with these rules https://github.com/protomaps/PMTiles/blob/main/js/biome.json to ease the transition from Prettier. `useNamingConvention` makes things easier and since I'll need to push a breaking major version 3.0 soon, I'm introducing...
3.0 will also change to `exports: {require:..., import:...}` in package.json which should make ES6 modules everywhere the default, but also support CommonJS only for NodeJS.
Reading through your link https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c?permalink_comment_id=3850849#gistcomment-3850849 it looks like there are some risks with the dual `exports` to support both ESM and CJS. So I'll take another look at going ESM-only...
This should do it https://github.com/protomaps/PMTiles/commit/0d0b3ee2ada422ff070d76e4673f7d9abb72a2d9 @sachaw what instructions/tools should we give people that need CJS from the new esm-only package?
as of https://github.com/protomaps/PMTiles/pull/337/files I have the uses of `any` reduced to 2: `declare const L: any;`: we need to assume `L` exists in the global environment to make sure IIFE...