Brandon Liu

Results 553 comments of Brandon Liu

This should be fixed in tomorrow's build (4.0.0-alpha.3)

![CleanShot 2024-08-24 at 20 09 01@2x](https://github.com/user-attachments/assets/555ee2db-ba9a-4505-8a63-3c1dcdda5802) https://maps.protomaps.com/#map=6.75/46.177/0.022&theme=light&tiles=https://build.protomaps.com/20240824.pmtiles The name mismatches should be resolved in the daily tile build, the hosted API should be updated in a few weeks with v4.

Agree, this would be useful. Ideally it should be an option for each table with a geometry column.

The tile resolution should match your devicePixelRatio and be the ideal resolution automatically, so there isn't a way to set it: https://github.com/protomaps/protomaps-leaflet/blob/main/src/frontends/leaflet.ts#L107

In the case you described shouldn't setting `deviceScaleFactor` in Puppeteer be sufficient for control over this?

I agree, do you want to try a PR where `devicePixelRatio` is an option to `leafletLayer`?

`scale` can mean something different and I think `devicePixelRatio` used like ```js this.devicePixelRatio || window.devicePixelRatio ``` is the most straightforward... > since you're not actually changing the device pixel ratio...

I worked around it using the JSON output, with CSV output I was running into problems with escaping: (adapted from https://github.com/bdon/overture-tiles): ```sql LOAD spatial; COPY ( SELECT 'Feature' as type,...

On v0.10.2-dev39 e245e2927f (macOS) ``` duckdb :memory: "load spatial; COPY (SELECT * FROM read_csv('test.csv')) TO '/vsistdout/' WITH (FORMAT 'gdal', DRIVER 'geojsonseq')" Not implemented Error: GDAL Error (6): Read or update...

LGTM! I'm open to making the upstream Reader async if that can address all use cases like writing quick and dirty CLI programs. Unfortunately it does seem like many python...