Brandon Liu

Results 553 comments of Brandon Liu

What is your complete, exact URL you are fetching from?

Yes, how are you specifying the URL passed to `leafletLayer`? Because the form of that string needs to be checked to determine whether it's a ZXY URL or a .pmtiles...

It should be fixed in v3.1.2, can you please check?

Thanks for checking, closing!

Should we throw an error if no `theme` is passed? It could be more explicit if we had positional arguments. In the future, the `lang` argument will also be required...

Thanks for the PR. I recall the issue here now, which is that if we pass this: `leafletLayer({paintRules:myPaintRules})` If I'm visualizing my own tileset, as of right now on main...

What if we created a 2nd entry point called like `leafletBasemapLayer("light", {"url":"...."})` to encapsulate this use case? Also, would a Typedoc page like this: https://protomaps.github.io/PMTiles/typedoc/ be helpful?

Thanks, I have not had the time to implement this yet. If you need custom styling of specific tags I’d recommend using maplibre instead

More screenshots would be appreciated! I think this needs small tweaks in the grid parameters, ideally we can test a few variations and compare screenshots directly.

> have 2 style layers for this so the big cities are labeled before admin-1 labels