Too many places visible at zoom 8, 9, and 10

[nvkelso]

While fixing https://github.com/protomaps/basemaps/issues/89 to add more state (region) labels, I inadvertently also added more locality labels. This was OK in the United States and Europe, but looks far too dense in India and China.

The grid size should probably be coarser at these mid-zooms (to disallow smaller rural localities from backfilling less populated areas of the map), and the number of allowed place labels should be slightly reduced (This could improve flickering in Paris at zoom 10).

private static final ZoomFunction<Number> LOCALITY_GRID_SIZE_ZOOM_FUNCTION =
    ZoomFunction.fromMaxZoomThresholds(Map.of(
      6, 32,
      7, 64
    ), 0);

  private static final ZoomFunction<Number> LOCALITY_GRID_LIMIT_ZOOM_FUNCTION =
    ZoomFunction.fromMaxZoomThresholds(Map.of(
      6, 8,
      7, 6,
      9, 4
    ), 0);

[makella]

@nvkelso also seeing this starting around z6 in the US and Mexico!

[bdon]

More screenshots would be appreciated!

I think this needs small tweaks in the grid parameters, ideally we can test a few variations and compare screenshots directly.

[makella]

ok, no problem! let me know if these are helpful

Example in Mexico - to Mexico City

z5:

z6:

z7:

z8:

z9:

z10: Mexico City label disappears

z11:

Example in the US - z6 there is noticeable increase and then again at z8

z5:

z6:

z7:

z8:

z9:

z10:

[bdon]

have 2 style layers for this so the big cities are labeled before admin-1 labels