Andrew Dirksen

Results 21 comments of Andrew Dirksen

That explanation definitely clears things up.

Publishing to crates-io is pretty easy in my experience. docs: https://doc.rust-lang.org/cargo/commands/cargo-publish.html Once published, docs will get built automatically and posted on docs.rs. You may have already seen this, but if...

> Do you recommend turning the version number back to below 1.0.0? I heard online that theres a certain "1.0.0 shyness" in the community. I can see why someone might...

Oh, please don't let my suggestions stop you from pushing an initial release. The first version doesn't need perfect formatting, etc. `shame` is ready as-is. Not trying to gatekeep.

I'm about to use the term "blank-node hygiene". "blank-node hygiene" means when a new graph is added, its blank nodes don't get conflated with those already in the store. `load_graph`...

How does this look for a start? ```rust instance .export_by_name(func_name)? .as_func()? .with_externals(&mut NopExternals) .with_args(&args)? .invoke() .ok()?; ``` `export_by_name() -> Option` and `as_func() -> Option` already exist. The rest could be...

I can submit a pr, just checking first to see if this is approach it useful.

`Interpreter::new` creates new value stack with size `DEFAULT_VALUE_STACK_LIMIT`. `Interpreter::run_interpreter_loop` checks it's frame stack against `DEFAULT_CALL_STACK_LIMIT`. I think the first step should be `Interpreter::new` taking value stack limit and frame stack...

Ok, backing out of the weeds here. On a higher level, It seems like `ModuleInstance` should hold value and frame stack limits. That way the user can optionally set those...

You are right. I've been fiddling with `runner.rs` and I think it would make most sense to write a stack struct with upper bound checking. Both the call stack and...