bdbch comments

Results 344 comments of


                                            bdbch

CollaborationCaret crashes with "Cannot read properties of undefined (reading 'doc')"

Thanks, I triaged the bug and will look into it.

CollaborationCaret crashes with "Cannot read properties of undefined (reading 'doc')"

Looked into it but wasn't able to replicate it with our local demos. Based off the callstack it seems like the decorations are being created before the actual prosemirror doc...

fix(extension-unique-id): check next node attribute before transaction modification

I'm there just catching up on a few things over the last few days of the year. I'll try to review your PR soon

Fix #3084 - remove old newline-fix for ios that freezes safari on ios

Since this is reintroducing the bug mentioned by @fenok I'd rather would like to fix this issue instead of removing the fix. Do you see any option how to fix...

Fix #3084 - remove old newline-fix for ios that freezes safari on ios

@nperez0111 since you mentioned me here for a review: I think we need to double verify this PR and make sure it doesn't introduce the double-line issue again (as @fenok...

[Mention extension] Get reference to `window` from editor view element to support cross-window instantiation

Closed in favor for #5534 since we needed to merge develop & add changesets

Feature: Search and Replace Extension

Thanks @Aslam97, will take a look into the demo and fix it when I come back to it.

[PRO]: When the scrollParent is different than window, onUpdate callback of TableOfContents extension is not called on scroll

I have a PR open for this. Passing through the scrollParent will be required to use callback functions in the future: ```js TableOfContents.configure({ // ... scrollParent: () => scrollRef.current })...

Add profile hover cards to more screens

Looking forward for feedback on this. I'd love to see more profile cards in a few places (as described above).

Add profile hover cards to more screens

Sure thing, will do. Should I look into linking for new tabs for starter packs in a new PR?