bdbch comments

Results 338 comments of


                                            bdbch

fix(extension-suggestion): get client rect by anchor.

Just to clarify a little bit more - which decoration node are we talking about here? For suggestions I usually used the `posToDOMRect` util function that is included in `@tiptap/core`,...

fix(extension-suggestion): get client rect by anchor.

@YonLJ could you rebase this to the current develop branch as we released V3, deprecating the next branch & would need to update most of our PR's anyway? Thanks a...

fix: preserve table cell selection when opening context menu (#6396)

@ay690 could you rebase this to the current develop branch as we released V3, deprecating the next branch & would need to update most of our PR's anyway? Thanks a...

Feature: Add a person to a starter pack from their profile page

Good idea. In general the UI to add people to an already existing starter kit is weird because I didn't see that I have to click on "Next" to add...

[Bug]: NodePos.children out of range

@AdeboyeDN feel free to pick it up

[PRO]: extension-unique-id does not maintain ids

Thanks, will take a look into it.

[PRO]: extension-unique-id does not maintain ids

Found the issue and opening a PR now

[Bug]: getPos for NodeView errors on 2nd render with React 19.1

Ah just saw your comment here: https://github.com/ProseMirror/prosemirror/issues/1532 Insight from Marjin was nice to have. I think we could look into this on the long run but for now I don't...

[Bug]: getPos for NodeView errors on 2nd render with React 19.1

Have to reopen as I had to revert the removal of `flushSync` - I didn't find a good way to make React & ProseMirror render nicely without it and it...

[Bug]: getPos for NodeView errors on 2nd render with React 19.1

Thanks @phwebi, will push a fix for that issue today.