Ben Darnell
Ben Darnell
Thanks, all these changes look great. I'm not expecting to see any savings in execution time and CI costs, but the new assertion methods give much better error messages when...
Why do you think it's "stuck in initializing"? `IOLoop.start` is *supposed* to run forever; that's the main event loop of the application. Your `print("Ready")` is in the wrong place; it...
Yes, this should have a test to make sure it doesn't get broken in the future. Something like ContextVarsTest in gen_test.py. I'm a little surprised this is necessary - I...
I think this belongs in Tornado itself, although maybe it should first be introduced as a separate package so we can be sure we have the API right. Whatever we...
I still think it makes sense to try and get something for this into Tornado directly. We have two implementations mentioned in this thread, one by @Lookyan and one by...
That link is broken for me, but yes, if you've got something that is your own work feel free to use it instead of one of the other implementations linked...
You definitely shouldn't be looking at `IOLoop._callbacks` or `IOLoop._timeouts`. In addition to being private variables, there's a good chance that they will never be empty, for reasons that are unimportant...
Yeah, I think adding something to "Running and deploying" makes sense. There are two tricky things in writing this up: A) The right way to do this depends heavily on...
Tornado works correctly under the upstart configuration you described - it dies by default when it gets SIGTERM. What would you like it to do differently? This always seems to...