Ben Darnell

Results 362 comments of Ben Darnell

I prefer to keep this as a tuple. Logically it should have been a set, but whether it's a set or a tuple the interface of modifying SUPPORTED_METHODS is awkward...

Can you say more about how exactly this happens? It's true that we don't strip the value when parsing content-length, but it's supposed to already be stripped in the last...

> Got it; now I can reproduce the bug. Agreed that this is a problem. I'm still not clear on what exactly the problem is. Is there an issue with...

Aha, now I see the problem. Single-line headers have leading and trailing whitespace stripped, while continuation lines make it possible to construct a header with trailing whitespace, potentially confusing users...

That exact message ("Tornado was blocked for more than 1 second") doesn't appear in Tornado, although it's similar to the message we had for `set_blocking_log_threshold` (and we now have through...

This makes sense, but does it ever matter in practice? It doesn't seem worth the (small) performance cost of an extra re.match call. However, I think we could merge the...

Ah, I see. [RFC 9110 section 9.1](https://www.rfc-editor.org/rfc/rfc9110#name-overview) also distinguishes between methods that are not recognized (501) and those that are recognized but not supported by the target resource (405). The...

Thanks! The fix looks good. Is it feasible to add a test? I guess we don't have good test infrastructure for manipulating individual frames like this. I've used Autobahn (https://github.com/crossbario/autobahn-testsuite)...

> Is this expected behavior / is there some reason I'm missing for why a reference cycle forms here? I don't have a ton of experience with Tornado directly so...

> Just want to understand why there is an impact of 4.25x in performance when the size of message is just increased by 1.4x. It seems likely that you're hitting...